Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-1834] Adds Splunk Flakeguard uploads #15718

Merged
merged 21 commits into from
Dec 20, 2024
Merged

[TT-1834] Adds Splunk Flakeguard uploads #15718

merged 21 commits into from
Dec 20, 2024

Conversation

kalverra
Copy link
Collaborator

No description provided.

@kalverra kalverra requested review from AKhozya and lukaszcl December 16, 2024 20:40
@kalverra kalverra requested review from a team as code owners December 16, 2024 20:40
lukaszcl
lukaszcl previously approved these changes Dec 20, 2024
@kalverra kalverra enabled auto-merge December 20, 2024 14:47
AKhozya
AKhozya previously approved these changes Dec 20, 2024
AKhozya
AKhozya previously approved these changes Dec 20, 2024
lukaszcl
lukaszcl previously approved these changes Dec 20, 2024
@kalverra kalverra dismissed stale reviews from lukaszcl and AKhozya via 18c45b4 December 20, 2024 17:43
Copy link
Contributor

github-actions bot commented Dec 20, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@@ -446,7 +464,7 @@ jobs:
fi

- name: Post comment on PR if flaky tests found
if: ${{ fromJSON(steps.results.outputs.summary).flaky_tests > 0 && github.event_name == 'pull_request' }}
if: ${{ (success() || failure()) && fromJSON(steps.results.outputs.summary).flaky_tests > 0 && github.event_name == 'pull_request' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this different from always()?

Suggested change
if: ${{ (success() || failure()) && fromJSON(steps.results.outputs.summary).flaky_tests > 0 && github.event_name == 'pull_request' }}
if: ${{ always() && fromJSON(steps.results.outputs.summary).flaky_tests > 0 && github.event_name == 'pull_request' }}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, always() will also trigger if the workflow has been cancelled, which we would rather not do here. It's not a huge difference, but could stop some confusion.

@kalverra kalverra added this pull request to the merge queue Dec 20, 2024
Merged via the queue into develop with commit 30b857b Dec 20, 2024
100 of 101 checks passed
@kalverra kalverra deleted the flakeguardAnalysis branch December 20, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants